[Webkit-unassigned] [Bug 230929] Nullptr deref when accessing m_value.calc in CSSPrimitiveValue::primitiveType()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230929

--- Comment #9 from Gabriel Nava Marino <gnavamarino at apple.com> ---
(In reply to Darin Adler from comment #7)
> Comment on attachment 439936 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439936&action=review
> 
> > Source/WebCore/css/CSSPrimitiveValue.cpp:435
> > +    // TODO(webrtc:231111): this init should take Ref<CSSCalcValue> instead
> 
> This comment is not yet the right format for WebKit coding style:
> 
> 1) We use FIXME, not TODO.
> 2) Not sure what "webrtc:" is about, OK to put a bug number in though.
> 3) We use sentence style, with a capital letter at the start, and a period
> at the end.

Thank you, I have updated the format per the recommended style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211004/841abe73/attachment.htm>