[Webkit-unassigned] [Bug 231101] [WinCairo] Support run-jsc-stress-tests without posix commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231101

--- Comment #2 from Angelos Oikonomopoulos <angelos at igalia.com> ---
Oops. Patch looks reasonable.

Minor nit: looks like you can avoid repeating Dir.chdir by hoisting it out of the if/else?

Even more minor nit: you can implement a

class StatusFileEnumerator
    def each_line
        Dir.glob("#{STATUS_FILE_PREFIX}*").each do |name|
            if File.size(name) > 0
                line = File.open(name).first
                yield "./#{name} #{line}"
            end
        end
    end
end

and then do something like

Dir.chdir($runnerDir) {
    statusFileEnumerator = StatusFileEnumerator.new
    if $testRunnerType != :ruby and $testWriter != "playstation"
        statusFileEnumerator = IO.popen(find_cmd)
    end
    statuFileEnumerator.each_line {
        | line |
        processStatusLine(map, line)
    }
}

but that might be overkill :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211004/10c5ead0/attachment.htm>