[Webkit-unassigned] [Bug 230735] Add a module map file for PrivateFrameworks/WebKitLegacy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 1 17:20:18 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=230735

--- Comment #11 from Ian Anderson <iana at apple.com> ---
Comment on attachment 439918
  --> https://bugs.webkit.org/attachment.cgi?id=439918
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439918&action=review

>> Source/WebKitLegacy/mac/Misc/NSURLDownloadSPI.h:29
>> +#if (defined TARGET_OS_MACCATALYST && TARGET_OS_MACCATALYST)
> 
> This is formatted a bit odd compared to other places where macro values are checked, and I'm not entirely sure it's doing what's intended, so I'd suggest fixing it:
> 
> #if defined(TARGET_OS_MACCATALYST) && TARGET_OS_MACCATALYST

I did think it looked weird when I copied it, though it does seem to work since the #else doesn't get hit. Should I just change it here or also in WebDownload.h where I copied it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211002/6487bedb/attachment.htm>


More information about the webkit-unassigned mailing list