[Webkit-unassigned] [Bug 230735] Add a module map file for PrivateFrameworks/WebKitLegacy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230735

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #439918|review?                     |review-
              Flags|                            |

--- Comment #9 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 439918
  --> https://bugs.webkit.org/attachment.cgi?id=439918
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439918&action=review

r- but r+ with the "#if defined" macro checks fixed.

> Source/WebKitLegacy/mac/Misc/NSURLDownloadSPI.h:29
> +#if (defined TARGET_OS_MACCATALYST && TARGET_OS_MACCATALYST)

This is formatted a bit odd compared to other places where macro values are checked, and I'm not entirely sure it's doing what's intended, so I'd suggest fixing it:

#if defined(TARGET_OS_MACCATALYST) && TARGET_OS_MACCATALYST

> Source/WebKitLegacy/mac/Misc/NSURLDownloadSPI.h:31
> +#elif !TARGET_OS_IPHONE || (defined USE_APPLE_INTERNAL_SDK && USE_APPLE_INTERNAL_SDK)

Same here:

#elif !TARGET_OS_IPHONE || (defined(USE_APPLE_INTERNAL_SDK) && USE_APPLE_INTERNAL_SDK)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211002/e89b3542/attachment-0001.htm>