[Webkit-unassigned] [Bug 230736] WebKitLegacy's module map files don't get installed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230736

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #439122|review?                     |review-, commit-queue-
              Flags|                            |

--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 439122
  --> https://bugs.webkit.org/attachment.cgi?id=439122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439122&action=review

r-, but just don't revert the two `#if defined(...) & ...` changes.

>> Source/WebKitLegacy/ios/WebView/WebUIKitDelegate.h:133
>> +#if ENABLE_ORIENTATION_EVENTS
> 
> Should be ENABLE(ORIENTATION_EVENTS)

Actually, we can't use ENABLE(ORIENTATION_EVENTS) here because this is a public or private header, and we can't assume the ENABLE() macro is defined here when this is included outside of a WebKit build.

We should NOT revert this change, or the other one like it below.

>> Source/WebKitLegacy/mac/WebView/WebHTMLViewPrivate.h:116
>> +#if ENABLE_NETSCAPE_PLUGIN_API
> 
> Should be ENABLE(NETSCAPE_PLUGIN_API)

Actually, we can't use ENABLE(NETSCAPE_PLUGIN_API) here because this is a public or private header, and we can't assume the ENABLE() macro is defined here when this is included outside of a WebKit build.

We should NOT revert this change, or the other one like it above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211001/ffc6e480/attachment.htm>