[Webkit-unassigned] [Bug 232420] Selection extend() should trigger exception with no ranges

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232420

--- Comment #16 from Brandon <brandonstewart at apple.com> ---
Comment on attachment 442859
  --> https://bugs.webkit.org/attachment.cgi?id=442859
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442859&action=review

>> Source/WebCore/page/DOMSelection.cpp:343
>> +        return Exception { InvalidStateError, "The 'extend' method requires a Range object to be added to the Selection object before calling this method." };
> 
> I think I'd prefer a message like: "extend() cannot be called on an empty selection"

I am good with increasing the terseness of the current message, but we should still mention the missing range object.

Other browsers make it a point to mention it too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211029/88c87245/attachment.htm>