[Webkit-unassigned] [Bug 230258] [GTK][a11y] Add implementation of text interface when building with ATSPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 29 10:14:32 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=230258

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org

--- Comment #7 from Michael Catanzaro <mcatanzaro at gnome.org> ---
It introduced this warning:

[824/1963] Building CXX object Source/...sources/UnifiedSource-aba958d6-1.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-1.cpp:3:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/accessibility/AXObjectCache.cpp:1404:13: warning: ‘bool WebCore::isPasswordFieldOrContainedByPasswordField(WebCore::AccessibilityObject*)’ defined but not used [-Wunused-function]
 1404 | static bool isPasswordFieldOrContainedByPasswordField(AccessibilityObject* object)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Can you check the #if guards, please? It's easy enough to guard the newly-unused function, but I'm not sure whether your change in AXObjectCache::enqueuePasswordValueChangeNotification was intentional.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211029/bb168782/attachment.htm>


More information about the webkit-unassigned mailing list