[Webkit-unassigned] [Bug 232318] Possible non-unified build issues

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 28 10:00:38 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=232318

--- Comment #7 from Don Olmstead <don.olmstead at sony.com> ---
(In reply to Don Olmstead from comment #6)
> Comment on attachment 442688 [details]
> fixed style (no functional changes)
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442688&action=review
> 
> I'll just r+ this on Fujii's behalf but in the future that's the workflow
> when you get an r+ but a cq-.
> 
> > Source/WebKit/ChangeLog:6
> > +        Reviewed by NOBODY (OOPS!).
> 
> When you get an r+ in a previous patch with nits what you do is you replace
> the `NOBODY (OOPS!)` and then a cq+ is all that's needed.

In this case the line would've been

Reviewed by Fujii Hironori.

You can just search the ChangeLog and copy paste the reviewer's name from there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211028/def9e7bb/attachment-0001.htm>


More information about the webkit-unassigned mailing list