[Webkit-unassigned] [Bug 232409] Assertions in findFirstSlotElement hit when removing two slots with the same name in a single shadow tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232409

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #442641|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 442641
  --> https://bugs.webkit.org/attachment.cgi?id=442641
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442641&action=review

> LayoutTests/fast/shadow-dom/slot-removal-same-name.html:1
> +<script>

Missing DOCTYPE?

> LayoutTests/fast/shadow-dom/slot-removal-same-name.html:3
> +    let shadow0 = document.body.attachShadow({mode: 'open'});

Can we call this just shadowRoot?
Also, use const since we're reassigning another value to it.

> LayoutTests/fast/shadow-dom/slot-removal-same-name.html:6
> +    document.body.offsetTop;

document.body.getBoundingClientRect() is more sure way of ensuring updating the layout.
offsetTop can be optimized in some cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211027/62c2240c/attachment.htm>