[Webkit-unassigned] [Bug 232373] Macro assembler scratchRegister() is unsafe on ARMv7, MIPS and RISCV64

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232373

--- Comment #4 from Geza Lore <glore at igalia.com> ---
(In reply to Saam Barati from comment #3)
> (In reply to Geza Lore from comment #2)
> > On ARMv7 sometimes we need both scratch registers reserved for the macro
> > assembler, so the best we might be able to do is a RELEASE_ASSERT when we
> > handed out the scratch GPR but then end up needing it. Still would be better
> > than the current situation. Other than that caveat, we could add support for
> > this.
> 
> I think you're misunderstanding what DisallowMacroScratchRegisterUsage does.
> All it does is crash if we use the scratch register. It's not preventing us
> from using it.

Yes I was wondering about that actually. In that case this should definitely work in all macro assemblers, though currently it does not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211027/b88eaa0a/attachment.htm>