[Webkit-unassigned] [Bug 232141] AX: Notify about children changed earlier in isolated tree mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232141

--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Andres Gonzalez from comment #7)
> (In reply to Carlos Garcia Campos from comment #6)
> > (In reply to Andres Gonzalez from comment #5)
> > > (In reply to Carlos Garcia Campos from comment #2)
> > > > Created attachment 442147 [details]
> > > > Patch
> > > 
> > > +        non-isolated tree mode, but then it's deferred again by the
> > > notification post timer. This affects layout tests
> > > +        doing things like foo.appendChild(bar) + foo.childAtIndex(0),
> > > because in isolated tree mode foo.childAtIndex(0)
> > > +        returns null, the child wrapper hasn't been attached yet with the
> > > ax isolated object.
> > > +
> > > 
> > > That is true for all properties, not only for children. I believe we have to
> > > make the LayoutTests async, i.e., waitFor foo.childAtIndex(0) is not null in
> > > your example above.
> > 
> > We are already notifying early other properties, though. I wonder how the
> > tests pass in mac with isolated tree enabled.
> 
> Where are we notifying early other properties?

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/accessibility/AXObjectCache.cpp#L1476
https://github.com/WebKit/WebKit/blob/main/Source/WebCore/accessibility/AXObjectCache.cpp#L1515
https://github.com/WebKit/WebKit/blob/main/Source/WebCore/accessibility/AXObjectCache.cpp#L1723
https://github.com/WebKit/WebKit/blob/main/Source/WebCore/accessibility/AXObjectCache.cpp#L1774

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211026/3acba075/attachment.htm>