[Webkit-unassigned] [Bug 232130] AX: AccessibilityObject::m_haveChildren and AXCoreObject::hasChildren() are misleadingly named

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232130

--- Comment #12 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Tyler Wilcock from comment #10)
> Created attachment 442314 [details]
> Patch

--- a/Source/WebCore/accessibility/AccessibilitySpinButton.cpp
+++ a/Source/WebCore/accessibility/AccessibilitySpinButton.cpp
@@ -45,9 +45,9 @@ AccessibilitySpinButton::~AccessibilitySpinButton() = default;

 AXCoreObject* AccessibilitySpinButton::incrementButton()
 {
-    if (!m_haveChildren)
+    if (!m_childrenInitialized)
         addChildren();
-    if (!m_haveChildren)
+    if (!m_childrenInitialized)
         return nullptr;

Does this second check for m_childrenInitialized even make sense? Since addChildren should set it to true by definition.

Same for AccessibilitySpinButton::decrementButton.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211025/da7ad898/attachment.htm>