[Webkit-unassigned] [Bug 232079] [JSC][32bit] Use DataIC in Baseline JIT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232079

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #442137|review?                     |review+
              Flags|                            |

--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 442137
  --> https://bugs.webkit.org/attachment.cgi?id=442137
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442137&action=review

r=me with comment.

> Source/JavaScriptCore/jit/JITCall.cpp:-415
> -    emitJumpSlowCaseIfNotJSCell(baseGPR);

We should insert `static_assert(BaselineGetByIdRegisters::baseJSR == BaselineGetByIdRegisters::resultJSR);`.
We have baseJSR. And it is possible that we will change baseJSR while keeping resultJSR value.
Then, it is wrong that this code's base value register is not changed. To notice that we are using returnValueJSR here instead, we should put static_assert so that compilation error will happen.
baseJSR and resultJSR are the same, but this is not guaranteed thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211023/9083bfcf/attachment-0001.htm>