[Webkit-unassigned] [Bug 232079] [JSC][32bit] Use DataIC in Baseline JIT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232079

--- Comment #5 from Geza Lore <glore at igalia.com> ---
Comment on attachment 442042
  --> https://bugs.webkit.org/attachment.cgi?id=442042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442042&action=review

>> Source/JavaScriptCore/jit/JITCall.cpp:488
>>  
> 
> It looks like original 64bit code had baseGPR (and move was done), but it is removed. Can you recover that?
> And we were using different registers for JITGetByIdGenerator's returnValueJSR, resultJSR previously.

returnValueJSR is generic and defined at the top of the file as the JSValueRegs holding the ABI return value register/registers. We want to pass the result of the function call above to the IC generator, which happen to be in returnValueGPR (ABI), which also happens to be the same as regT0 (GPRInfo.h), and baseGPR also was defined to regT0 (JITInlineCacheGenerator.h), so that move emitted nothing and it was just a roundabout way of saying pass in the return value of the previous function call that I can't see there is a need for.

With that in mind, I left this in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211022/e533ec07/attachment.htm>