[Webkit-unassigned] [Bug 232130] AX: AccessibilityObject::m_haveChildren and AXCoreObject::hasChildren() are misleadingly named

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232130

--- Comment #6 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 442120
  --> https://bugs.webkit.org/attachment.cgi?id=442120
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442120&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3493
> +    if (role == AccessibilityRole::SVGRoot && !childrenInitialized())

this looks like an incorrect usage due to poor naming. I think we want to return role is Image if it doesn't have children, not that it wasn't initialized

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211022/5eca4568/attachment-0001.htm>