[Webkit-unassigned] [Bug 232052] [JSC][32bit] Re-enable compileEnumeratorGetByVal fast path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 16:05:09 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=232052

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #442016|review?                     |review-
              Flags|                            |

--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 442016
  --> https://bugs.webkit.org/attachment.cgi?id=442016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442016&action=review

r- since the new code is not great compared to the current 64bit implementation.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:15891
> +            flushRegisters();
> +

This is regressing 64bit implementation from the current one.
Can you remove it?
If this is necessary for 32bit implementation, so please keep 32bit and 64bit implementations separated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211021/bbcbe40f/attachment.htm>


More information about the webkit-unassigned mailing list