[Webkit-unassigned] [Bug 231114] [WebAssembly][modules] Importing globals into Wasm from JS doesn't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231114

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #441794|review?                     |review+
              Flags|                            |

--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 441794
  --> https://bugs.webkit.org/attachment.cgi?id=441794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441794&action=review

r=me

> Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp:840
>          return jsModuleRecord->evaluate(globalObject, sentValue, resumeMode);

Replace it with

RELEASE_AND_RETURN(scope, jsModuleRecord->evaluate(globalObject, sentValue, resumeMode));

since scope is defined now.

> Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp:848
>          return wasmModuleRecord->evaluate(globalObject);

Replace it with

RELEASE_AND_RETURN(scope, wasmModuleRecord->evaluate(globalObject));

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211021/0ca7ca3d/attachment.htm>