[Webkit-unassigned] [Bug 232080] Enable logging in under non-systemd linux distros
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 21 08:52:05 PDT 2021
https://bugs.webkit.org/show_bug.cgi?id=232080
--- Comment #5 from ablocorrea at gmail.com ---
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 442026 [details]
> Patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442026&action=review
>
> > w/Source/WTF/wtf/Logger.h:244
> > -#if USE(SYSTEMD)
> > +#if USE(JOURNALD)
>
> If you're changing the name of the public build option to
> ENABLE_JOURNALD_LOG, then also change its usage in the code to
> ENABLE(JOURNALD_LOG).
>
> > w/Source/cmake/OptionsWPE.cmake:240
> > SET_AND_EXPOSE_TO_BUILD(USE_JOURNALD TRUE)
>
> Then here you would SET_AND_EXPOSE_TO_BUILD(ENABLE_JOURNALD_LOG TRUE)
Makes sense and should also help tracking the source of the macro. Consequently, I have also renamed all entries of USE(JOURNALD) to ENABLE(JOURNALD_LOG)
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211021/84c943b9/attachment-0001.htm>
More information about the webkit-unassigned
mailing list