[Webkit-unassigned] [Bug 231923] Commit ecbb6e69c1bd can cause build break.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231923

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Hironori.Fujii at sony.com

--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 441742
  --> https://bugs.webkit.org/attachment.cgi?id=441742
Patch to fix build break.

View in context: https://bugs.webkit.org/attachment.cgi?id=441742&action=review

> Source/WebCore/ChangeLog:11
> +        ecbb6e69c1bda8ac90a08f7e857207596b9b9c5 has access to RenderBlockFLow's method

WebKit doesn't have such commit.
https://github.com/WebKit/WebKit/commit/ecbb6e69c1bda8ac90a08f7e857207596b9b9c5

No one uses Git hash to point revision. 
Use Identifiers (243111 at main), or SVN revision (r284315).
https://github.com/WebKit/WebKit/wiki/Source-Control#identifiers

> Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h:30
> +#include "RenderBlockFlow.h"

This file doesn't use RenderBlockFlow. I think this is wrong fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211019/fadc9541/attachment-0001.htm>