[Webkit-unassigned] [Bug 231914] AX: Any addition of children should funnel through AccessibilityObject::addChild
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 19 10:18:54 PDT 2021
https://bugs.webkit.org/show_bug.cgi?id=231914
--- Comment #14 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 441675
--> https://bugs.webkit.org/attachment.cgi?id=441675
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=441675&action=review
>>> Source/WebCore/accessibility/AccessibilityObject.cpp:-518
>>> - ASSERT(child->parentObject() == this);
>>
>> do we still want this parent object assert too?
>
> Yeah, spoke to Andres and we think this ASSERT might not be that useful in its current form, since it is often verifying DOM parent-child relationship rather than AX tree parent-child relationships. There are several cases where DOM parent-child relationships are validly not how the AX tree is structured (i.e. aria-owns, tables, autofill buttons). I'm just going to remove it.
I’ve seen this assert to be useful in the past when we mess up the parent child hierarchy for mock elements or other kinds of custom sub classes
Is it asserting now in your tests?
>>> Source/WebCore/accessibility/AccessibilityTableRow.cpp:155
>>> + if (ariaOwnedElements.size()) {
>>
>> this size check seems unnecessary now
>
> That would be a change in behavior from the current:
>
> Either add "aria-owns" elements as m_children, _or_ AccessibilityRenderObject::addChildren() (aka DOM children) as m_children.
>
> Your suggestion would be unconditionally adding both aria-owns children and DOM children to m_children.
>
> Based on the definition of aria-owns (https://www.w3.org/TR/2017/REC-wai-aria-1.1-20171214/#aria-owns), your suggestion seems right.
Agreed based on that reading. We need to make that change. And we’ll need a test for it. Could be separate patch
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211019/676b5a65/attachment.htm>
More information about the webkit-unassigned
mailing list