[Webkit-unassigned] [Bug 231914] AX: Any addition of children should funnel through AccessibilityObject::addChild

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 19 08:29:40 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=231914

--- Comment #10 from Tyler Wilcock <tyler_w at apple.com> ---
(In reply to Andres Gonzalez from comment #7)
> (In reply to Tyler Wilcock from comment #3)
> > Created attachment 441675 [details]
> > Patch
> 
> @@ -3381,12 +3379,7 @@ void AccessibilityRenderObject::addRemoteSVGChildren()
>      // In order to connect the AX hierarchy from the SVG root element from
> the loaded resource
>      // the parent must be set, because there's no other way to get back to
> who created the image.
>      root->setParent(this);
> -
> -    if (root->accessibilityIsIgnored()) {
> -        for (const auto& child : root->children())
> -            m_children.append(child);
> -    } else
> -        m_children.append(root);
> +    addChild(root);
> 
> addChild would need to do the same type of deep append, i.e., if the root is
> ignored, try to add its children.

`AccessibilityObject::addChild` calls `AccessibilityObject::insertChild`, which does exactly this :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211019/0e793487/attachment.htm>


More information about the webkit-unassigned mailing list