[Webkit-unassigned] [Bug 231919] New: WebAVPlayerController should use WeakPtr<> for C++ instance variables

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231919

            Bug ID: 231919
           Summary: WebAVPlayerController should use WeakPtr<> for C++
                    instance variables
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: darin at apple.com, eric.carlson at apple.com,
                    jer.noble at apple.com, peng.liu6 at apple.com,
                    rniwa at webkit.org

WebAVPlayerController should use WeakPtr<> for C++ instance variables.

The "rules" I'm following here are:
- RefCounted objects should be held weakly instead of using raw pointers (WebCore::PlaybackSessionInterfaceAVKit).
  - I assume this isn't a RefPtr<> to prevent a retain cycle.
- Delegate objects should always be held weakly (WebCore::PlaybackSessionModel, which already subclasses WeakPtr<>).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211018/fda2ba73/attachment.htm>