[Webkit-unassigned] [Bug 231882] New: WebKit::GPUConnectionToWebProcess::setTCCIdentity() leaks a tcc_identity_t

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231882

            Bug ID: 231882
           Summary: WebKit::GPUConnectionToWebProcess::setTCCIdentity()
                    leaks a tcc_identity_t
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: achristensen at apple.com, katherine_cheney at apple.com,
                    kkinnunen at apple.com

WebKit::GPUConnectionToWebProcess::setTCCIdentity() leaks a tcc_identity_t.

See Bug 231621, Comment #24 from Alex Christensen:

> Comment on attachment 441298 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441298&action=review
> 
> > Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm:81
> > +    identity = tcc_identity_create(TCC_IDENTITY_CODE_BUNDLE_ID, [bundleProxy.bundleIdentifier UTF8String]);
> 
> tcc_identity_create is annotated with OS_OBJECT_RETURNS_RETAINED, which
> means this is probably a memory leak.  It should probably be auto identity =
> adoptOSObject(tcc_identity_create(...)); which means my build fix of calling
> tcc_identity_t will probably also need to be changed to OS_OBJECT_DECL if
> OS_OBJECT_USE_OBJC is defined.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211017/498e8835/attachment.htm>