[Webkit-unassigned] [Bug 231670] [GLIB] Simplify SleepDisabler by checking if we are under sandbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231670

--- Comment #10 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Carlos Garcia Campos from comment #9)
> isInsideFlatpak is not exactly the same in this case, that caches the result
> and it's used by the process launcher to see if we are already under
> flatpak. 

> If we are not under flatpak false will be cached, but then the
> bubblewrap launcher will create the flatpak-info, but isInsideFlatpak will
> return false. That's why isInsideSandbox doesn't cache the result.

The .flatpak-info is created in the filesystem namespace of the sandboxed subprocess that is going to be launched. The UI process won't see it. Both isInsideSandbox and isInsideFlatpak would behave the same: you're just doing extra work in the case of isInsideSandbox.

You can safely change isInsideSandbox to cache its result.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211016/12973b7e/attachment.htm>