[Webkit-unassigned] [Bug 231692] Move Safe Browsing knowledge into SafariSafeBrowsing framework

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231692

Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andersca at apple.com

--- Comment #3 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 441457
  --> https://bugs.webkit.org/attachment.cgi?id=441457
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441457&action=review

> Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:40
>  static const char* malwareDetailsBase(SSBServiceLookupResult *result)

You probably want to have this return String otherwise the memory returned by strdup will be leaked.

> Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:62
>  static const char* reportAnErrorBase(SSBServiceLookupResult *result)

You probably want to have this return String otherwise the memory returned by strdup will be leaked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211016/0efed7cb/attachment.htm>