[Webkit-unassigned] [Bug 231339] Add support for icons in web app manifest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231339

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bfulgham at webkit.org

--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 441423
  --> https://bugs.webkit.org/attachment.cgi?id=441423
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=441423&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=231339

Please include <rdar> here.

> Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:194
> +        logDeveloperWarning(makeString("The value of icons is not a valid list."_s));

I think you can just pass "The value of icons is not a valid list."_s

> Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:341
> +String ApplicationManifestParser::parseGenericStringInIcon(RefPtr<WTF::JSONImpl::Object> &manifest, const String& propertyName)

In C++, space should be after the ampersand

> Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.h:57
> +    String parseGenericStringInIcon(RefPtr<WTF::JSONImpl::Object> &, const String&);

No space before the ampersand.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211015/b2dc5117/attachment.htm>