[Webkit-unassigned] [Bug 231819] Add tests for WTF::OSObjectPtr/adoptOSObject in Cocoa with and without ARC

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 15 11:08:03 PDT 2021


--- Comment #1 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
(In reply to David Kilzer (:ddkilzer) from comment #0)
> I suspect that WTF::OSObjectPtr/adoptOSObject probably leaks objects under
> ARC (and there is at least one using of it in an Objective-C++ source file
> in WTF), but I can't quite nail down a failing test.  (I think the test may
> be flakey based on whether MRR or ARC code is kept during linking.)

Actually, because WTF::OSObjectPtr uses the correct type to store the object (and doesn't type-pun to CFTypeRef), we might not leak.  The only issue may be some ref-churn when using adoptOSObject().

And doing this:

#define adoptOSObject adoptOSObjectArc

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211015/55c756c4/attachment.htm>

More information about the webkit-unassigned mailing list