[Webkit-unassigned] [Bug 231794] Reject createImageBitmap request earlier if the image is null. Also, check that the native image is nonnull when requesting the colorspace, otherwise, return a default of SRGB.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231794

Cameron McCormack (:heycam) <heycam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heycam at apple.com

--- Comment #3 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 441331
  --> https://bugs.webkit.org/attachment.cgi?id=441331
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441331&action=review

Non-reviewer r=me.

> Source/WebCore/ChangeLog:3
> +        Reject createImageBitmap request earlier if the image is null. Also, fix a null ptr deref by checking that the native image is nonnull when requesting the colorspace, otherwise, return a default of SRGB.

Nit: Two sentences is a bit long for this line. :-) I would mention the more important fix here like "Avoid null pointer dereference when creating ImageBitmap from a null image", and then put the details about defaulting to sRGB and rejecting the promise earlier below, just below the "Reviewed by" line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211015/b07cbb0c/attachment-0001.htm>