[Webkit-unassigned] [Bug 230622] Allow DFG to use regCS0 GPR (LLInt metadataTable) on ARMv7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 12:37:49 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=230622

--- Comment #17 from Geza Lore <glore at igalia.com> ---
> I'm pretty confused as to what this is doing and why it's needed.
> 
> > Source/JavaScriptCore/jit/CallFrameShuffleData.cpp:64
> > +        VirtualRegister saveSlot { saveSlotIndexInCPURegisters / 2 };
> 
> Why /2?

there are two (32-bit) CPU register save slots per one (64-bit) virtual register slot on the stack. csr0/csr1 both need to map onto the first virual register slot (that's where the prologue puts them), but are in different halves (paload/tag). If we had csr2/csr3 would go into the second virtual register slot, hence the /2 (and the peculiar rounding bias above)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211014/aba8b5a1/attachment.htm>


More information about the webkit-unassigned mailing list