[Webkit-unassigned] [Bug 231667] AX: Build with isolated tree enable is broken since r284075

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231667

--- Comment #10 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Carlos Garcia Campos from comment #9)
> (In reply to Andres Gonzalez from comment #7)
> > (In reply to Carlos Garcia Campos from comment #6)
> > > So, forward declaration worked for me locally, but it seems to be failing in
> > > the bots, maybe it worked for me thanks to unified builds.
> > 
> > what's the error? Does it need to be included in
> > WebAccessibilitWrapperMac.mm since now we call a SessionID method there?
> 
> Still fails:
> 
> CompileC
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/arm64/
> UnifiedSource5-mm.o
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource5-mm.
> mm normal arm64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>     cd
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/Source/
> WebCore
>     export LANG=en_US.US-ASCII
>    
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.
> xctoolchain/usr/bin/clang -x objective-c++ -target arm64-apple-macos11.0
> -fmessage-length=0 -fdiagnostics-show-note-include-stack
> -fmacro-backtrace-limit=0 -std=gnu++1z -stdlib=libc++ -fobjc-weak -gmodules
> -Wno-trigraphs -fno-exceptions -fno-rtti -fno-sanitize=vptr -fpascal-strings
> -O0 -fno-common -Werror -Wno-missing-field-initializers -Wmissing-prototypes
> -Wunreachable-code -Wno-implicit-atomic-properties -Wno-objc-interface-ivars
> -Wno-arc-repeated-use-of-weak -Wimplicit-retain-self -Wnon-virtual-dtor
> -Wno-overloaded-virtual -Wno-exit-time-destructors -Wduplicate-method-match
> -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function
> -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value
> -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow
> -Wno-four-char-constants -Wno-conversion -Wconstant-conversion
> -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion
> -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wsign-compare
> -Wno-shorten-64-to-32 -Wnewline-eof -Wno-selector -Wno-strict-selector-match
> -Wundeclared-selector -Wdeprecated-implementations -Wno-c++11-extensions
> -DBUILDING_WEBKIT -DGL_SILENCE_DEPRECATION=1 -DGLES_SILENCE_DEPRECATION=1
> -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -isysroot
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk -fstrict-aliasing -Wprotocol
> -Wdeprecated-declarations -Winvalid-offsetof -g -fvisibility=hidden
> -fvisibility-inlines-hidden -fno-threadsafe-statics -Wno-sign-conversion
> -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing
> -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body
> -iquote
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/WebCore-generated-files.hmap
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/WebCore-own-target-headers.
> hmap
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/WebCore-all-target-headers.
> hmap -iquote
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/WebCore-project-headers.hmap
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/include -IPAL -IForwardingHeaders
> -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/include/libxslt
> -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/include/libxml2
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/DerivedSources/WebCore
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/usr/local/include
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/usr/local/include/WebKitAdditions
> -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/local/include/WebKitAdditions
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/usr/local/include
> -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/local/include
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/usr/local/include/webrtc
> -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/local/include/webrtc
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/usr/local/include/webrtc/sdk/objc/Framework/Headers
> -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/local/include/webrtc/sdk/objc/Framework/
> Headers
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> Source/WebCore
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/DerivedSources-normal/arm64
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/DerivedSources/arm64
> -I/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/DerivedSources -Wall -Wextra
> -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens
> -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn
> -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings
> -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare
> -Wimplicit-fallthrough -Wvla -Wno-unknown-warning-option
> -Wliteral-conversion -Wthread-safety
> -F/Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug -iframework
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/System/Library/PrivateFrameworks -iframework
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/System/Library/Frameworks -isystem
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/System/Library/Frameworks/System.framework/
> PrivateHeaders -include
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/PrecompiledHeaders/WebCorePrefix-ffvuycgpgqmrgwckroztacgbwjza/
> WebCorePrefix.h -MMD -MT dependencies -MF
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/arm64/
> UnifiedSource5-mm.d --serialize-diagnostics
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/arm64/
> UnifiedSource5-mm.dia -c
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource5-mm.
> mm -o
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/arm64/
> UnifiedSource5-mm.o
> In file included from
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/
> WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource5-mm.
> mm:1:
> In file included from
> /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/Source/
> WebCore/WebCorePrefix.h:68:
> In file included from
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/algorithm:640:
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:3005:38: error:
> incomplete type 'PAL::SessionID' used in type trait expression
>     : public integral_constant<bool, __is_constructible(_Tp, _Args...)>
>                                      ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:3060:14: note:
> in instantiation of template class
> 'std::__1::is_constructible<PAL::SessionID, const PAL::SessionID &>'
> requested here
>     : public is_constructible<_Tp,
>              ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/
> Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:3066:7: note:
> in instantiation of template class
> 'std::__1::is_copy_constructible<PAL::SessionID>' requested here
>     = is_copy_constructible<_Tp>::value;
>       ^

Ah sorry. Last try: could you please #include in AXIsolatedTree.h? It may be needed there to size the Variant that now includes SessionID.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211014/d0128fd7/attachment.htm>