[Webkit-unassigned] [Bug 231667] AX: Build with isolated tree enable is broken since r284075

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231667

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Andres Gonzalez from comment #3)
> (In reply to Carlos Garcia Campos from comment #2)
> > Created attachment 441054 [details]
> > Patch
> 
> --- a/Source/WebCore/accessibility/AccessibilityObject.cpp
> +++ a/Source/WebCore/accessibility/AccessibilityObject.cpp
> 
> -uint64_t AccessibilityObject::sessionID() const
> +PAL::SessionID AccessibilityObject::sessionID() const
>  {
> ...
> -    return 0;
> +    return
> PAL::SessionID(PAL::SessionID::SessionConstants::HashTableEmptyValueID);
>  }
> 
> Can we do return { }; instead?

I don't think so.

SessionID() = delete;

> --- a/Source/WebCore/accessibility/AccessibilityObjectInterface.h
> +++ a/Source/WebCore/accessibility/AccessibilityObjectInterface.h
> @@ -34,6 +34,7 @@
>  #include "TextIteratorBehavior.h"
>  #include "VisibleSelection.h"
>  #include "Widget.h"
> +#include <pal/SessionID.h>
> 
> Can we do a forward declaration of SessionID instead of a full include here?
> Since this file is included quite a bit, this may have a build time impact.
> There is some ongoing work to improve build time and it seems that forward
> declaring things help.

Let me try. 

> --- a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
> +++ a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
> 
> -uint64_t AXIsolatedObject::sessionID() const
> +PAL::SessionID AXIsolatedObject::sessionID() const
>  {
> ...
> +    return
> PAL::SessionID(PAL::SessionID::SessionConstants::HashTableEmptyValueID);
>  }
> 
> Can we do return { }; instead?
> 
> +PAL::SessionID AXIsolatedObject::sessionIDAttributeValue(AXPropertyName
> propertyName) const
> +{
> ...
> +        [] (auto&) { return
> PAL::SessionID(PAL::SessionID::SessionConstants::HashTableEmptyValueID); }
> +    );
> +}
> 
> Same as above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211013/31c0b518/attachment.htm>