[Webkit-unassigned] [Bug 231667] New: AX: Build with isolated tree enable is broken since r284075

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231667

            Bug ID: 231667
           Summary: AX: Build with isolated tree enable is broken since
                    r284075
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cgarcia at igalia.com
                CC: achristensen at apple.com, andresg_22 at apple.com,
                    cdumez at apple.com, webkit-bug-importer at group.apple.com

It happens at least with GCC:

In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-7.cpp:8:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: In member function ‘void WebCore::AXIsolatedObject::initializeAttributeData(WebCore::AXCoreObject&, bool)’:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:415:64: error: cannot convert ‘uint64_t’ {aka ‘long unsigned int’} to ‘WebCore::AXPropertyValueVariant&&’ {aka ‘std::variant<std::nullptr_t, WTF::String, bool, int, unsigned int, double, float, long unsigned int, WebCore::Color, WTF::URL, WebCore::LayoutRect, WebCore::FloatRect, long unsigned int, WebCore::IntPoint, WTF::OptionSet<WebCore::SpeakAs>, std::pair<unsigned int, unsigned int>, WTF::Vector<WebCore::AccessibilityText, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<long unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<std::pair<long unsigned int, long unsigned int>, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WebCore::Path>&&’}
  415 |         setProperty(AXPropertyName::SessionID, object.sessionID());
      |                                                ~~~~~~~~~~~~~~~~^~
      |                                                                |
      |                                                                uint64_t {aka long unsigned int}
In file included from ../../Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp:24,
                 from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-7.cpp:6:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:77:38: note:   initializing argument 2 of ‘void WebCore::AXIsolatedObject::setProperty(WebCore::AXPropertyName, WebCore::AXPropertyValueVariant&&, bool)’
   77 |     void setProperty(AXPropertyName, AXPropertyValueVariant&&, bool shouldRemove = false);
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-7.cpp:8:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: In member function ‘void WebCore::AXIsolatedObject::setObjectProperty(WebCore::AXPropertyName, WebCore::AXCoreObject*)’:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:469:51: error: cannot convert ‘WebCore::AXID’ {aka ‘long unsigned int’} to ‘WebCore::AXPropertyValueVariant&&’ {aka ‘std::variant<std::nullptr_t, WTF::String, bool, int, unsigned int, double, float, long unsigned int, WebCore::Color, WTF::URL, WebCore::LayoutRect, WebCore::FloatRect, long unsigned int, WebCore::IntPoint, WTF::OptionSet<WebCore::SpeakAs>, std::pair<unsigned int, unsigned int>, WTF::Vector<WebCore::AccessibilityText, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<long unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<std::pair<long unsigned int, long unsigned int>, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WebCore::Path>&&’}
  469 |         setProperty(propertyName, object->objectID());
      |                                   ~~~~~~~~~~~~~~~~^~
      |                                                   |
      |                                                   WebCore::AXID {aka long unsigned int}
In file included from ../../Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp:24,
                 from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-7.cpp:6:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:77:38: note:   initializing argument 2 of ‘void WebCore::AXIsolatedObject::setProperty(WebCore::AXPropertyName, WebCore::AXPropertyValueVariant&&, bool)’
   77 |     void setProperty(AXPropertyName, AXPropertyValueVariant&&, bool shouldRemove = false);
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~

The problem seems to be that AXPropertyValueVariant contains the same type twice (in 64 bit systems) AXID (size_t -> long unsigned int) and uint64_t -> long unsigned int. That's actuallt allowed but makes the access ambiguous. Since uint64_t is only used for SessionID, I think we can explicitly use SessionID instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211013/94dc1358/attachment-0001.htm>