[Webkit-unassigned] [Bug 230906] Adopt platform UI for WebAuthn

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 16:21:28 PDT 2021


--- Comment #14 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 440851
  --> https://bugs.webkit.org/attachment.cgi?id=440851

View in context: https://bugs.webkit.org/attachment.cgi?id=440851&action=review

>> Source/WebKit/SourcesCocoa.txt:595
>> +UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
> If you added a new file to the project, that file still needs to show up in the Xcode project (otherwise searches will ignore the file).
> That means you'll have to add the file to the Xcode project, but not add it to any build targets (or it will get built twice and link failures will occur).
> So there should be a corresponding change to add the file to the Xcode project (but not build it since it's built by the Unified Sources mechanism).
> This must be fixed before landing the patch.

Please ignore this comment--I thought I deleted it, and the Xcode change is already much further down in the patch.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211012/1a0c03c2/attachment.htm>

More information about the webkit-unassigned mailing list