[Webkit-unassigned] [Bug 231491] Implement parsing and animation support for offset-distance, offset-position, offset-anchor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231491

--- Comment #8 from Kiet Ho <tho22 at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 440736 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440736&action=review
> 
> Looks like you need to rebase more tests.
What do you mean by rebasing here?

> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests; WPT parsing tests are sufficient.
> 
> If bits of this patch are from external contributors, you should acknowledge
> them here.
> 
> > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3180
> > +        case CSSPropertyObjectPosition:
> > +            return valueForPosition(style, style.objectPosition());
> > +        case CSSPropertyOffsetDistance:
> > +            return cssValuePool.createValue(style.offsetDistance(), style);
> > +        case CSSPropertyOffsetPosition:
> > +            return valueForPositionOrAuto(style, style.offsetPosition());
> > +        case CSSPropertyOffsetAnchor:
> > +            return valueForPositionOrAuto(style, style.offsetAnchor());
> 
> You can also use your helper for CSSPropertyPerspectiveOrigin, maybe others.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211012/f1b0e57b/attachment.htm>