[Webkit-unassigned] [Bug 231491] Implement parsing and animation support for offset-distance, offset-position, offset-anchor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 02:24:13 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=231491

--- Comment #6 from Kiet Ho <tho22 at apple.com> ---
Comment on attachment 440736
  --> https://bugs.webkit.org/attachment.cgi?id=440736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440736&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests; WPT parsing tests are sufficient.
> 
> If bits of this patch are from external contributors, you should acknowledge them here.

I'll mention WPT tests that cover the implemented properties.

>> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3180
>> +            return valueForPositionOrAuto(style, style.offsetAnchor());
> 
> You can also use your helper for CSSPropertyPerspectiveOrigin, maybe others.

In the current code perspective-origin is parsed as a shorthand for some reason :/ If we ever change perspective-origin to use this helper, then it'd be for another patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211012/a3e130f1/attachment.htm>


More information about the webkit-unassigned mailing list