[Webkit-unassigned] [Bug 231362] [JSC][32bit] Fix wrong branchAdd32 assembly for ARMv7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231362

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #440530|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 440530
  --> https://bugs.webkit.org/attachment.cgi?id=440530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440530&action=review

r=me with changes.

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:200
> +    void add32(TrustedImm32 imm, Address address, bool updateFlags = false)

Let's define it as add32Impl helper private function, and define add32 as

void add32(TrustedImm32 imm, Address address)
{
    constexpr bool updateFlags = false;
    add32Impl(imm, address, updateFlags);
}

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:229
> +    void add32(TrustedImm32 imm, AbsoluteAddress address, bool updateFlags = false)

Let's define it as add32Impl helper private function, and define add32 as

void add32(TrustedImm32 imm, AbsoluteAddress address)
{
    constexpr bool updateFlags = false;
    add32Impl(imm, address, updateFlags);
}

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1861
> +        add32(imm, dest, true);

Let's make it readable by,

constexpr bool updateFlags = true;
add32(imm, dest, updateFlags);

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1867
> +        add32(imm, dest, true);

Let's make it readable by,

constexpr bool updateFlags = true;
add32(imm, dest, updateFlags);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211011/c3d49199/attachment.htm>