[Webkit-unassigned] [Bug 230622] Allow DFG to use regCS0 GPR (LLInt metadataTable) on ARMv7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 9 02:52:48 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=230622

--- Comment #15 from Geza Lore <glore at igalia.com> ---
Comment on attachment 440492
  --> https://bugs.webkit.org/attachment.cgi?id=440492
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440492&action=review

>> Source/JavaScriptCore/bytecode/ValueRecovery.h:195
>> +    static ValueRecovery calleeSaveRegDisplacedInJSStack(VirtualRegister virtualReg, bool inTag)
> 
> why is the implication here that we're dealing with an Int32?

On 32-bit platforms up to two 32-bit machine registers (which look like Int32) are stored in a single 64-bit VirtualRegister slot on the stack on procedure entry. Reusing the Int32 recovery mechanism takes care of restoring the one stored in the "payload" half of the VReg. I added the Int32Tag mechanism to restore the other 32-bit machine reg from the other half of the VReg.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211009/b58f3c54/attachment.htm>


More information about the webkit-unassigned mailing list