[Webkit-unassigned] [Bug 231432] New: Web Inspector: Move CSS longhand and shorthand mapping away from WI.CSSCompletions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231432

            Bug ID: 231432
           Summary: Web Inspector: Move CSS longhand and shorthand mapping
                    away from WI.CSSCompletions
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: rcaliman at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

`WI.CSSCompletions` has scope creep. Beyond handling filtering for CSS completions, it holds logic to deal with CSS property name longhand-to-shorthand mapping and checks.

But `WI.CSSCompletions` already relies heavily on metadata about properties set on `WI.CSSKeywordCompletions`. 
Moreover, the one-time initialization from `WI.CSSCompletions.initializeCSSCompletions(target)` > `WI.CSSKeywordCompletions.addCustomCompletions(properties)` already puts most of the metadata about CSS properties on:

- `WI.CSSKeywordCompletions.LonghandNamesForShorthandProperty`
- `WI.CSSKeywordCompletions.PropertyNameForAlias`
- `WI.CSSKeywordCompletions.InheritedProperties`

It makes sense to also move the longhand-to-shorthand mapping from `WI.CSSCompletions` to `WI.CSSKeywordCompletions`. 
This keep mapping and checks co-located. 

This is prep work for gradually removing `WI.CSSCompletions.cssNameCompletions` as a needlessly specialized completions manager.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211008/3c60e749/attachment.htm>