[Webkit-unassigned] [Bug 217655] [WPE] PlatformDisplay::shutDownEglDisplays() is never called
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 8 01:47:36 PDT 2021
https://bugs.webkit.org/show_bug.cgi?id=217655
Claudio Saavedra <csaavedra at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cdumez at apple.com
--- Comment #11 from Claudio Saavedra <csaavedra at igalia.com> ---
Some git history:
- The _exit() call in AuxiliaryProcess was added by cdumez as part of bug #177972 to prevent processes from taking too long to exit. It is not clear to me whether using exit(2) instead would have been acceptable too, I think it should be OK.
- The one in WebProcess is basically a specialization of what should be done on connection closure and was added as part of bug #190294, also by cdumez. Similarly, I don't see a reason why exit() can't be used.
Chris, do you think we could safely switch _exit() to exit() in these classes?
There are also other uses of _exit() for similar reasons that are not relevant to this bug (in PluginProcess and NetworkProcess), that I think should probably also be changed to exit(), but I don't have a strong opinion there since we don't have exit handlers that need to be honored there.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211008/1783e860/attachment.htm>
More information about the webkit-unassigned
mailing list