[Webkit-unassigned] [Bug 231362] [JSC][32bit] Fix wrong branchAdd32 assembly for ARMv7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231362

--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 440502
  --> https://bugs.webkit.org/attachment.cgi?id=440502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440502&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1859
> +        // Do the add.
> +        ARMThumbImmediate armImm = ARMThumbImmediate::makeEncodedImm(imm.m_value);
> +        if (armImm.isValid())
> +            m_assembler.add_S(dataTempRegister, dataTempRegister, armImm);
> +        else {
> +            move(imm, addressTempRegister);
> +            m_assembler.add_S(dataTempRegister, dataTempRegister, addressTempRegister);
> +        }

Can we add an add32 with flags helper that is this? It seems like that could be useful elsewhere in this file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211007/114ebd51/attachment.htm>