[Webkit-unassigned] [Bug 231331] [JSC] Temporal tweaks to pass more test262 tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=231331

--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 440443
  --> https://bugs.webkit.org/attachment.cgi?id=440443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440443&action=review

Quick comment

> Source/JavaScriptCore/runtime/TemporalObject.h:67
> +// https://tc39.es/proposal-temporal/#table-temporal-temporaldurationlike-properties
> +static constexpr TemporalUnit temporalUnitsInTableOrder[numberOfTemporalUnits] = {
> +    TemporalUnit::Day,
> +    TemporalUnit::Hour,
> +    TemporalUnit::Microsecond,
> +    TemporalUnit::Millisecond,
> +    TemporalUnit::Minute,
> +    TemporalUnit::Month,
> +    TemporalUnit::Nanosecond,
> +    TemporalUnit::Second,
> +    TemporalUnit::Week,
> +    TemporalUnit::Year,
> +};

Let's put the array content to cpp file to avoid materializing the same constant array multiple times. This will enlarge binary size.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211006/63b29f98/attachment.htm>