[Webkit-unassigned] [Bug 231231] AX: Move handling of AXContents from platform wrapper to AX core
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 6 07:00:47 PDT 2021
https://bugs.webkit.org/show_bug.cgi?id=231231
--- Comment #5 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Tyler Wilcock from comment #2)
> Created attachment 440266 [details]
> Patch
--- a/Source/WebCore/accessibility/AccessibilityObjectInterface.h
+++ a/Source/WebCore/accessibility/AccessibilityObjectInterface.h
+ virtual void contents(AccessibilityChildrenVector&) = 0;
Should be
virtual AccessibilityChildrenVector contents() = 0;
No need to pass an out parameter. Out parameters are bad and make client code less clear unnecessarily.
Also, can we make this method const:
virtual AccessibilityChildrenVector contents() const = 0;
or some of the function calls in the implementation cannot be const.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211006/83ca666e/attachment.htm>
More information about the webkit-unassigned
mailing list