[Webkit-unassigned] [Bug 229826] [JSC] Implement Temporal.Instant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229826

--- Comment #17 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 439756
  --> https://bugs.webkit.org/attachment.cgi?id=439756
Patch for preliminary review

View in context: https://bugs.webkit.org/attachment.cgi?id=439756&action=review

Added some more style nits.

> Source/JavaScriptCore/runtime/TemporalDuration.cpp:170
> +const ISO8601::Duration TemporalDuration::toLimitedDuration(JSGlobalObject* globalObject, JSValue itemValue, std::initializer_list<TemporalUnit> disallowedUnits)

This const is not necessary.

> Source/JavaScriptCore/runtime/TemporalDuration.h:49
> +    static const ISO8601::Duration toLimitedDuration(JSGlobalObject*, JSValue, std::initializer_list<TemporalUnit> disallowedUnits);

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.cpp:48
> +TemporalInstant::TemporalInstant(VM& vm, Structure* structure, const ISO8601::ExactTime exactTime)

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.cpp:60
> +TemporalInstant* TemporalInstant::create(VM& vm, Structure* structure, const ISO8601::ExactTime exactTime)

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.cpp:70
> +TemporalInstant* TemporalInstant::tryCreateIfValid(JSGlobalObject* globalObject, const ISO8601::ExactTime exactTime, Structure* structure)

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.cpp:246
> +const ISO8601::Duration TemporalInstant::difference(JSGlobalObject* globalObject, TemporalInstant* other, JSValue optionsValue) const

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.cpp:308
> +const ISO8601::ExactTime TemporalInstant::round(JSGlobalObject* globalObject, JSValue optionsValue) const

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.cpp:385
> +String TemporalInstant::toString(const ISO8601::ExactTime exactTime, JSObject* timeZone, PrecisionData precision)

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.h:46
> +    static TemporalInstant* create(VM&, Structure*, const ISO8601::ExactTime);

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.h:47
> +    static TemporalInstant* tryCreateIfValid(JSGlobalObject*, const ISO8601::ExactTime, Structure* = nullptr);

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.h:61
> +    constexpr const ISO8601::ExactTime exactTime() const { return m_exactTime; }

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.h:64
> +    const ISO8601::Duration difference(JSGlobalObject*, TemporalInstant*, JSValue options) const;
> +    const ISO8601::ExactTime round(JSGlobalObject*, JSValue options) const;

const iISO8601::XXX's const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.h:72
> +    TemporalInstant(VM&, Structure*, const ISO8601::ExactTime);

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.h:77
> +    static const ISO8601::ExactTime fromObject(JSGlobalObject*, JSObject*);

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstant.h:79
> +    static String toString(const ISO8601::ExactTime, JSObject* timeZone, PrecisionData);

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstantPrototype.cpp:118
> +    const ISO8601::Duration duration = TemporalDuration::toLimitedDuration(globalObject, callFrame->argument(0), disallowedAdditionUnits);

const is not necessary.

> Source/JavaScriptCore/runtime/TemporalInstantPrototype.cpp:139
> +    const ISO8601::Duration duration = TemporalDuration::toLimitedDuration(globalObject, callFrame->argument(0), disallowedAdditionUnits);

const is not necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211006/06aba1b2/attachment.htm>