[Webkit-unassigned] [Bug 233651] New: Follow-up fixes for modern units in legacy CSS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233651

            Bug ID: 233651
           Summary: Follow-up fixes for modern units in legacy CSS
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

This patch corrects a few items that Darin pointed out after the patch for Bug 22977 landed.

> https://bugs.webkit.org/attachment.cgi?id=437335&action=review
> 
> > Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp:94
> > +    case CSSUnitType::CSS_X:                            return 37;
> 
> Please don’t add this. We don’t need to expose modern units in the legacy
> CSS primitive value object model. Also, this patch has no test coverage for
> this. Just return CSS_UNKNOWN for tis case.
> 
> If you have a different strategy in mind, please add new test cases
> demonstrating what we intend, and consider adding a constant to the IDL file.
> 
> > Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp:136
> > +    case 37:                return m_value->getFloatValue(CSSUnitType::CSS_X);
> 
> Please don’t add this. Same reason as above.

This patch resolves these two issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211130/18a2b75b/attachment-0001.htm>