[Webkit-unassigned] [Bug 233513] New: GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233513

            Bug ID: 233513
           Summary: GraphicsContextGLOpenGL.cpp contains OpenGL
                    implementation specific and platform specific code
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGL
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: kkinnunen at apple.com
                CC: dino at apple.com, kbr at google.com, kkinnunen at apple.com
            Blocks: 221664

GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code

This blocks the task of removing ifdefs from GraphicsContextGLOpenGL.h by means of separating various code paths to separate classes.

GraphicsContextGLOpenGL.cpp should contain only "OpenGL" specific code. Currently that code lives in GraphicsContextGLOpenGLCommon.cpp, so GraphicsContextGLOpenGL.cpp should be made empty and then ultimately GraphicsContextGLOpenGLCommon.cpp would be renamed to GraphicsContextGLOpenGL.cpp

ANGLE specific code should go into GraphicsContextGLANGLE.cpp

Platform specific code should go into platform specific files such as GraphicsContextGLCocoa.cpp and compositor specific files such as GraphicsContextGLTextureMapper.cpp.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=221664
[Bug 221664] Make GraphicsContectGL ANGLE implementation easier to edit correctly
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211126/4cdcefda/attachment.htm>