[Webkit-unassigned] [Bug 233511] New: Investigate if ScriptBufferSourceProvider could do without having to flatten underlying SharedBuffer
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 25 22:04:32 PST 2021
https://bugs.webkit.org/show_bug.cgi?id=233511
Bug ID: 233511
Summary: Investigate if ScriptBufferSourceProvider could do
without having to flatten underlying SharedBuffer
Product: WebKit
Version: Other
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebCore Misc.
Assignee: webkit-unassigned at lists.webkit.org
Reporter: jean-yves.avenard at apple.com
Seen in https://bugs.webkit.org/show_bug.cgi?id=233030#c13
ScriptBufferSourceProvider wraps a ScriptBuffer and ScriptBufferSourceProvider::source() flatten that ScriptBuffer's SharedBuffer to access the raw content and use this information to return a StringView.
A StringView is non-owning requiring ScriptBufferSourceProvider to take an extra reference to the flatten SharedBuffer so we have the content held in both the ScriptBuffer (non-flattened) and in ScriptBufferSourceProvider (flattened)
Ideally, we would have StringView keep a raw reference to the SharedBuffer and use SharedBuffer:read() to access the content when needed on demand.
Depends on the requirements: speed vs memory cost.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211126/2bc09542/attachment.htm>
More information about the webkit-unassigned
mailing list