[Webkit-unassigned] [Bug 233441] New: ScalableImageDecoder should be using SharedBuffer instead of DataSegment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 23 00:20:43 PST 2021


            Bug ID: 233441
           Summary: ScalableImageDecoder should be using SharedBuffer
                    instead of DataSegment
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Images
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jean-yves.avenard at apple.com
                CC: sabouhallawa at apple.com
        Depends on: 233030

In https://trac.webkit.org/changeset/251836/webkit DataSegment was used over SharedBuffer because SharedBuffer didn't use thread-safe refcounting.

However, since bug 230662, this is no longer the case.

Once bug 233030 lands, SharedBuffer becomes immutable once created and can be shared across threads.

ScalableImageDecoder currently takes a SharedBuffer, flatten it through the call to SharedBuffer::data() and then take a reference to the inner DataSegment.

ScalableImageDecoder should be re-written to use SharedBuffer so that we can do without the copy/memory allocation required by the flattening of the SharedBuffer.

Referenced Bugs:

[Bug 233030] Distinguish contiguous SharedBuffer from non-contiguous one and guarantee immutability
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211123/75f1c2ac/attachment.htm>

More information about the webkit-unassigned mailing list