[Webkit-unassigned] [Bug 232707] [GTK][a11y] Add implementation of hyperlink interface when building with ATSPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232707

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #444662|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 444662
  --> https://bugs.webkit.org/attachment.cgi?id=444662
Patch

Patch LGTM with a nit. Please apply the suggestion below before landing :)

View in context: https://bugs.webkit.org/attachment.cgi?id=444662&action=review

> Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:499
> +        if (--index == -1)

This modifies “index“ in place, which made me wonder “why, and where is the modified
value used later?“. But then it's not used again at all. So I would prefer to have
this check written this way for readability:

  if (index == 0)

=)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211118/e60ff1ad/attachment.htm>