[Webkit-unassigned] [Bug 229917] Correctly support fragment-only URLs in CSS images

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 18:16:26 PST 2021


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #444620|review?                     |review+
              Flags|                            |

--- Comment #29 from Darin Adler <darin at apple.com> ---
Comment on attachment 444620
  --> https://bugs.webkit.org/attachment.cgi?id=444620

View in context: https://bugs.webkit.org/attachment.cgi?id=444620&action=review

> Source/WebCore/css/parser/CSSParserContext.cpp:257
> +        if (CSSValue::isCSSLocalURL(string))
> +            return { string, { URL(), string } };
> +
>          if (charset.isEmpty())
>              return { string, { baseURL, string } };
>          auto encodingForURLParsing = TextEncoding { charset }.encodingForFormSubmissionOrURLParsing();

I think this might do the wrong thing when the fragment URLs contain non-ASCII characters since we are not taking the charset into account. We should make sure we have test cases for that.

I am not insisting that we add such test cases *before* landing this patch, but I strongly suspect we don’t have tests where the charset would make a difference, and we need to add them.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211118/aebdb82f/attachment.htm>

More information about the webkit-unassigned mailing list