[Webkit-unassigned] [Bug 230136] Implement 'gamepad' Permissions Policy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 17:35:03 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=230136

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #444603|review?                     |review+
              Flags|                            |

--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 444603
  --> https://bugs.webkit.org/attachment.cgi?id=444603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444603&action=review

> Source/WebCore/Modules/gamepad/NavigatorGamepad.h:30
> +#include "ExceptionOr.h"

It’s fine to include ExceptionOr.h and we have been doing that in other headers. But I’ve been wondering lately if we could get away with forward declarations instead in a case like this one.

    template<typename> class ExceptionOr;

That typically works for other return values in other similar cases, but for some reason we haven’t done that for ExecptionOr.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211118/6a39306e/attachment-0001.htm>


More information about the webkit-unassigned mailing list